Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpc calls to unregister recordings from catalog #8566

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Jan 2, 2025

What

This adds two simple rpc calls, UnregisterRecording and UnregisterAllRecordings, to the storage node interface.

@grtlr grtlr requested review from zehiko and jleibs and removed request for zehiko January 2, 2025 13:56
@grtlr grtlr changed the title feat: add rpc calls to unregister recordings from catalog Add rpc calls to unregister recordings from catalog Jan 2, 2025
@grtlr grtlr added dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
ca35002 https://rerun.io/viewer/pr/8566 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr grtlr merged commit ddaeb06 into main Jan 8, 2025
32 checks passed
@grtlr grtlr deleted the grtlr/remove-recording-protos branch January 8, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants