Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers: remove storageprofiles from storageclassrequest #2517

Merged
merged 3 commits into from
Mar 21, 2024
Merged

controllers: remove storageprofiles from storageclassrequest #2517

merged 3 commits into from
Mar 21, 2024

Conversation

jarrpa
Copy link
Member

@jarrpa jarrpa commented Mar 20, 2024

Signed-off-by: Jose A. Rivera [email protected]

@jarrpa jarrpa requested a review from nb-ohad March 20, 2024 19:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@jarrpa jarrpa requested a review from leelavg March 20, 2024 19:59
@leelavg
Copy link
Contributor

leelavg commented Mar 21, 2024 •
edited
Loading

Do I need to also rename/remove StorageProfile field in StorageClaims?

@jarrpa
Copy link
Member Author

jarrpa commented Mar 21, 2024

Do I need to also rename/remove StorageProfile field in StorageClaims?

...I wouldn't think so? It's just a string, I'm still making use of it here: https://github.com/red-hat-storage/ocs-operator/pull/2517/files#diff-30c208b17ae3a7fc2e92dbb904d5a5489f1a6d2837ca319525b5549c61a07256R406

leelavg
leelavg approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 108c0c4 into red-hat-storage:main Mar 21, 2024
11 checks passed
@leelavg
Copy link
Contributor

leelavg commented Mar 21, 2024

Although changes look good, my vote shouldn't have merged the PR 😕

@leelavg leelavg mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg approved these changes

@nb-ohad nb-ohad Awaiting requested review from nb-ohad

Assignees

@leelavg leelavg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarrpa @leelavg