label ceph svg correctly if datapool name is empty #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
suggested changes
Mar 25, 2024
controllers/storageclassrequest/storageclassrequest_controller.go
Outdated
Show resolved
Hide resolved
leelavg
force-pushed
the
fix-storageclassrequest
branch
from
06dddb6 to
4e4e220
Compare
leelavg
force-pushed
the
fix-storageclassrequest
branch
from
4e4e220 to
3a6dbda
Compare
|
/lgtm |
openshift-ci
bot
added
lgtm
leelavg
force-pushed
the
fix-storageclassrequest
branch
from
3a6dbda to
1e63ec0
Compare
|
rebased to pick CI changes. |
|
/lgtm |
|
/test ocs-operator-bundle-e2e-aws |
1 similar comment
|
/test ocs-operator-bundle-e2e-aws |
Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
fix-storageclassrequest
branch
from
1e63ec0 to
8bdc052
Compare
|
rebased. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, Madhu-1, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9d387da
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the datapool in cephfs is empty (aka default) the constructed resource label value ends with hyphen(
-) which isn't valid. This commit adds the suffix only if the datapool isn't empty (ref #2517)add rbac for provider-sa to query ceph radosnamespace (ref #2518)