Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated core to 13.26.0 #3502
Updated core to 13.26.0 #3502
Changes from 3 commits
0031c56
1c0817a
7741f40
3a27e94
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about this - I know it's just for tests, but if this is called with one of our integration apps, it would sets its sync route to a fake value, even though a real value should exist. I don't know if sync will refresh that route at some point, but I worry that as it stands, it's possible that running this test first, then running some integration tests that use the app, those will fail due to the route being misconfigured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmh, I understand. Good news is that all the tests are passing now, including sync tests, so I suppose it's not a problem "yet".
If we want to be more robust for the tests we could:
I am not sure if it's worth to do this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is the only holdup and it's only for tests, what do you think about merging this and creating a follow up ticket so we come back to it when the core investigation is finished?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Package / Unity
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / net7.0, win-x64
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Xamarin.macOS
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / net7.0, linux-x64
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / net7.0, osx-x64
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / net7.0, osx-arm64
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / net7.0, win81
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / .NET Framework
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / UWP
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Maui.Android
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Maui.MacCatalyst
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Maui.MacCatalyst
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Xamarin.iOS
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Maui.iOS
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Maui.iOS
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Xamarin.tvOS
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Woven classes
Check warning on line 279 in Tests/Realm.Tests/Sync/SyncTestBase.cs
GitHub Actions / Test / Code Coverage