Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated core to 13.26.0 #3502

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Updated core to 13.26.0 #3502

merged 4 commits into from
Jan 30, 2024

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Jan 23, 2024

Description

Fixes #3482

Copy link

coveralls-official bot commented Jan 23, 2024

Pull Request Test Coverage Report for Build 7640121693

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 80.957%

Totals Coverage Status
Change from base Build 7585695183: 0.001%
Covered Lines: 6405
Relevant Lines: 7787

💛 - Coveralls

@papafe
Copy link
Contributor Author

papafe commented Jan 24, 2024

@nirinchev this should fix both errors that came out from CI

  • The core method get_base_url now returns a copy of the string, and not a reference as before, and now we own the assume ownership of it
  • There's now an additional check done by core, that was crashing our app because the sync_route (the route to the server) was null. Added a method to set a fake route, that seems to be enough for our tests in which we create a fake local sync server. I've decided to keep it a separate method from the "GetSyncUserForTesting", but it's up for debate

Realm/Realm/Handles/AppHandle.cs Outdated Show resolved Hide resolved
Comment on lines +144 to +145
app ??= DefaultApp;
app.Handle.SetFakeSyncRouteForTesting();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about this - I know it's just for tests, but if this is called with one of our integration apps, it would sets its sync route to a fake value, even though a real value should exist. I don't know if sync will refresh that route at some point, but I worry that as it stands, it's possible that running this test first, then running some integration tests that use the app, those will fail due to the route being misconfigured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmh, I understand. Good news is that all the tests are passing now, including sync tests, so I suppose it's not a problem "yet".
If we want to be more robust for the tests we could:

  • Set the fake value only if the sync route is currently empty/null
  • Set it to null/empty again at the end of the test (if modified)
  • Maybe create infrastructure in core to create those fake synced realm more "organically"?
    I am not sure if it's worth to do this though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is the only holdup and it's only for tests, what do you think about merging this and creating a follow up ticket so we come back to it when the core investigation is finished?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Tests/Realm.Tests/Sync/SyncTestBase.cs Outdated Show resolved Hide resolved
@papafe papafe merged commit 46a8227 into main Jan 30, 2024
63 of 66 checks passed
@papafe papafe deleted the fp/update-core-13.26 branch January 30, 2024 15:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RealmException: posix_fallocate() failed
2 participants