Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ObjKey with RowKey in selected places #7852

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Jun 28, 2024

What, How & Why?

This will prevent us from accidently creating an ObjKey from something that cannot identify an Obj.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Jun 28, 2024

Pull Request Test Coverage Report for Build jorgen.edelbo_330

Details

  • 62 of 64 (96.88%) changed or added relevant lines in 7 files are covered.
  • 61 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.032%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/cluster.cpp 25 26 96.15%
src/realm/cluster_tree.hpp 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/realm/query_engine.hpp 1 94.15%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/noinst/server/server_history.cpp 1 63.7%
src/realm/query_expression.hpp 2 93.85%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/mixed.cpp 3 86.46%
src/realm/table.cpp 4 90.42%
src/realm/sync/noinst/client_impl_base.cpp 7 82.36%
src/realm/sync/noinst/server/server.cpp 14 73.67%
test/fuzz_group.cpp 26 48.33%
Totals Coverage Status
Change from base Build james.stone_566: 0.03%
Covered Lines: 215433
Relevant Lines: 236657

💛 - Coveralls

Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, type safety is our friend.

@ironage ironage merged commit 4f9dabe into js/removal-fixes Jun 28, 2024
2 of 5 checks passed
@ironage ironage deleted the je/removal-fixes branch June 28, 2024 23:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants