RCORE-2175 RCORE-2176 RCORE-2182 RCORE-2083 Fix several problems with object removal and links #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
approved these changes
Jun 21, 2024
Pull Request Test Coverage Report for Build james.stone_561Details
💛 - Coveralls |
|
CI caught another bug in the BPNODE = 4 configuration where the wrong backlinks were being removed. I think I fixed it as well, but I plan to add more tests next week. |
ironage
force-pushed
the
js/removal-fixes
branch
from
a5e874f to
d7b16c8
Compare
Pull Request Test Coverage Report for Build james.stone_563Details
💛 - Coveralls |
ironage
force-pushed
the
js/removal-fixes
branch
from
d7b16c8 to
8b65927
Compare
ironage
changed the title
ironage
changed the title
Pull Request Test Coverage Report for Build james.stone_564Details
💛 - Coveralls |
ironage
force-pushed
the
js/removal-fixes
branch
from
6304527 to
a23556e
Compare
Pull Request Test Coverage Report for Build james.stone_566Details
💛 - Coveralls |
tgoyne
approved these changes
Jun 26, 2024
CHANGELOG.md
Outdated
| @@ -6,7 +6,10 @@ | |||
|
|
|||
| ### Fixed | |||
| * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?) | |||
| * None. | |||
| * Fixed a change of mode from Strong to All when removing links from an embedded object that links to a tombstone. This affects sync apps that use embedded objects which have a `Lst<Mixed>` that contains a link to another top level object which has been deleted by another sync client (creating a tombstone locally). In this particular case, the switch would cause any remaining link removals to recursively delete the destination object if there were no other links to it. ([#7828](https://github.com/realm/realm-core/issues/7828), since 14.0.0-beta.0) | |||
| * Fixed `Table::remove_object_recursive` which wouldn't recursively follow links through a single `Mixed` property. ([#7829](https://github.com/realm/realm-core/issues/7829), likely since the introduction of Mixed) | |||
There was a problem hiding this comment.
This maybe goes under Internal since we don't actually expose remove_object_recursive().
There was a problem hiding this comment.
Valid point. It is part of core's public API, so I wasn't sure if this feature was exposed by any SDK or not.
jedelbo
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Very nice. I realize that using ObjKey parameters to hold something that does not actually identify an Obj was wrong. I have made #7852 as a PR to this PR. It introduces a new type - RowKey that can hold those internal keys, You are welcome to merge it if you like it.
Pull Request Test Coverage Report for Build james.stone_571Details
💛 - Coveralls |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered these when inspecting the code while investigating #7594
The first issue appears to have been a mistake, and was introduced by #6766
I don't know of any reports of the wrong objects being deleted so hopefully this is niche enough that nobody has been affected, but on the other hand maybe it is related to some of the
Key 'Number' not found in '<Class Name>'exceptions we have seen because unexpected objects are being deleted.The second issue is more benign, as fewer objects than expected may be deleted. The main thing there is that the state shouldn't have been ignored, and we already had a method for handling this.
The third issue was found due to CI running the new tests in the BPNODE=4 configuration. This uncovered a few other places in the code that had the same mistake: using the cluster local key instead of the "real" key. I renamed the variables there to hopefully make it clearer, and to avoid this mistake in the future.
The randomized testing that I added to cover the changes for the nested list/dictionary cases happened to trigger yet another bug which is the collapse/rejoin of clusters with nested collections and links.
Fixes #7828, #7829, #7839, #7594
☑️ ToDos
bindgen/spec.yml, if public C++ API changed