Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen checks for uids on exfat fs #7105

Merged
merged 1 commit into from
Nov 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/test_file.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,13 @@ TEST(File_GetUniqueID)
CHECK(uid2_1 == file2_1.get_unique_id());
}
else {
CHECK(uid1_1 == file2_1.get_unique_id());
CHECK(uid2_1 == file1_1.get_unique_id());
// fat32/exfat could reuse or reassign uid after truncate
// there is not much to guarantee about the values of uids
auto u1 = file1_1.get_unique_id();
auto u2 = file2_1.get_unique_id();
CHECK(u1 != u2);
auto u1_2 = file1_2.get_unique_id();
CHECK(u1 == u1_2);
}
}

Expand Down