Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen checks for uids on exfat fs #7105

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

kiburtse
Copy link
Contributor

@kiburtse kiburtse commented Nov 1, 2023

What, How & Why?

Apparently uids on fat32/exfat are assigned not so deterministically on truncate, so try to make simplier checks.

Example failure where most likely uids either stay the same or get completely new values:

[2023/10/30 23:39:13.137] Thread[08]: /System/Volumes/Data/data/mci/6327106b375800ccccaed93352fa5563/realm-core/test/test_file.cpp:588: ERROR in File_GetUniqueID: CHECK(uid1_1 == file2_1.get_unique_id()) failed
[2023/10/30 23:39:13.137] Thread[08]: /System/Volumes/Data/data/mci/6327106b375800ccccaed93352fa5563/realm-core/test/test_file.cpp:589: ERROR in File_GetUniqueID: CHECK(uid2_1 == file1_1.get_unique_id()) failed

or just one failure where it is probably just completely new uid for second file:

[2023/10/29 23:38:40.219] Thread[11]: /System/Volumes/Data/data/mci/60aa25829f9074ec643e693ea7f1f8cd/realm-core/test/test_file.cpp:589: ERROR in File_GetUniqueID: CHECK(uid2_1 == file1_1.get_unique_id()) failed

☑️ ToDos

~ * [ ] 📝 Changelog update ~

  • 🚦 Tests (or not relevant)
    ~ * [ ] C-API, if public C++ API changed. ~

Copy link

Pull Request Test Coverage Report for Build kirill.burtsev_100

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 120 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.009%) to 91.671%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/test_file.cpp 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
test/test_file.cpp 1 96.53%
test/test_util_network_ssl.cpp 1 90.71%
src/realm/sync/network/http.hpp 2 80.87%
src/realm/sync/network/websocket.cpp 2 75.15%
src/realm/table_view.cpp 2 94.18%
test/fuzz_group.cpp 2 52.57%
test/test_sync.cpp 2 94.03%
src/realm/util/future.hpp 3 95.97%
test/util/compare_groups.cpp 5 54.74%
src/realm/sync/network/network_ssl.hpp 8 85.95%
Totals Coverage Status
Change from base Build 1805: -0.009%
Covered Lines: 230678
Relevant Lines: 251638

💛 - Coveralls

@kiburtse kiburtse merged commit 2203fdd into master Nov 2, 2023
2 of 3 checks passed
@kiburtse kiburtse deleted the kb/lax_exfat_file_test branch November 2, 2023 17:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants