-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] EnvRunners fix min/max-metrics window sizes (from inf
to config.metrics_num_episodes_for_smoothing
).
#45575
[RLlib] EnvRunners fix min/max-metrics window sizes (from inf
to config.metrics_num_episodes_for_smoothing
).
#45575
Conversation
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
… '_log_episode_metrics' Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
self.metrics.log_value(EPISODE_RETURN_MIN, ret, reduce="min") | ||
self.metrics.log_value(EPISODE_LEN_MAX, length, reduce="max") | ||
self.metrics.log_value(EPISODE_RETURN_MAX, ret, reduce="max") | ||
self.metrics.log_value(EPISODE_LEN_MIN, length, reduce="min", window=win) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! That's why I always felt that min/max stats were lifetime (rather than win=100) :D
Makes perfect sense. Thanks for this fix @simonsays1980 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a ton for this important fix @simonsays1980
inf
to config.metrics_num_episodes_for_smoothing
).
Ah, wait, one fix still necessary. We need to do the same for
|
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Why are these changes needed?
The user defines the window size for metrics in
metrics_num_episodes_for_smoothing
. This needs to be applied to all episode metrics to keep consistency. This PR adds the missing ones for themin/max
which would otherwise report something different than themean
s.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.