[RLlib] EnvRunners fix min/max-metrics window sizes (from inf to `c…

…onfig.metrics_num_episodes_for_smoothing`). (#45575)
ray-project · May 28, 2024 · 5f01083 · 5f01083
1 parent d9761d7
commit 5f01083
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/rllib/env/multi_agent_env_runner.py b/rllib/env/multi_agent_env_runner.py
@@ -901,11 +901,13 @@ def _log_episode_metrics(self, length, ret, sec, agents=None, modules=None):
                 EPISODE_RETURN_MIN: ret,
             },
             reduce="min",
+            window=self.config.metrics_num_episodes_for_smoothing,
         )
         self.metrics.log_dict(
             {
                 EPISODE_LEN_MAX: length,
                 EPISODE_RETURN_MAX: ret,
             },
             reduce="max",
+            window=self.config.metrics_num_episodes_for_smoothing,
         )
diff --git a/rllib/env/single_agent_env_runner.py b/rllib/env/single_agent_env_runner.py
@@ -818,7 +818,7 @@ def _log_episode_metrics(self, length, ret, sec):
         )
 
         # For some metrics, log min/max as well.
-        self.metrics.log_value(EPISODE_LEN_MIN, length, reduce="min")
-        self.metrics.log_value(EPISODE_RETURN_MIN, ret, reduce="min")
-        self.metrics.log_value(EPISODE_LEN_MAX, length, reduce="max")
-        self.metrics.log_value(EPISODE_RETURN_MAX, ret, reduce="max")
+        self.metrics.log_value(EPISODE_LEN_MIN, length, reduce="min", window=win)
+        self.metrics.log_value(EPISODE_RETURN_MIN, ret, reduce="min", window=win)
+        self.metrics.log_value(EPISODE_LEN_MAX, length, reduce="max", window=win)
+        self.metrics.log_value(EPISODE_RETURN_MAX, ret, reduce="max", window=win)