-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDK Manager and updated CUDA install options #547
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ec91691
Add SDK Manager and updated install options
taureandyernv b119dbc
added more cuda versions
taureandyernv 9f2c53c
update CUDA version
taureandyernv bc99789
update CUDA section header
taureandyernv 827094a
fixed text
taureandyernv ed6eca8
fix CUDA section
taureandyernv a7ee893
Update install/index.md
taureandyernv 35b6f25
Update install/index.md
taureandyernv f7fa245
Update install/index.md
taureandyernv c8f6a4a
Update install/index.md
taureandyernv f7f90ab
Fix capitalization
taureandyernv cbdfa7d
dropped notes
taureandyernv 487eea8
Update install/index.md
taureandyernv 7d8aefc
added some code markers
taureandyernv 900f625
formatting
jameslamb 9e4bfc0
removed folder specific comments
taureandyernv a19bd45
Update index.md
taureandyernv f76cf52
Merge branch 'main' into sdkm
jameslamb e3e1b75
updated wsl2 install
taureandyernv baf65f6
Merge branch 'main' of github.com:rapidsai/docs into sdkm
jameslamb 07260ad
re-run pre-commit
jameslamb 26f318f
Update install/index.md
taureandyernv c646412
Update install/index.md
taureandyernv 0679716
Update install/index.md
taureandyernv 09d526f
Update install/index.md
taureandyernv afdd083
Update install/index.md
taureandyernv 464e5db
Update install/index.md
taureandyernv f5bd4f4
Update install/index.md
taureandyernv 178d916
made the install command for WSL2 copy and paste-able
taureandyernv 4fdcb5d
Remove trailing whitespace
bdice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this below pip? I think we should keep the order "Conda, Docker, pip, SDK Manager" to match the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should reorder this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taureandyernv could you please include this change?
It also lines up with the outline above it and the actual layout in the text below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taureandyernv let me know that @aravenel wants this at the top. I will defer to that decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To better understand, met with Taurean and Alex today
From that meeting, Taurean clarified that Windows users are primarily looking for a GUI installer, which this meets. Hence promoting this first for the Windows case
The Linux use case is intended to remain the same
Now with a better understanding, agree this is reasonable