Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK Manager and updated CUDA install options #547

Merged
merged 30 commits into from
Feb 3, 2025

Conversation

taureandyernv
Copy link
Contributor

@taureandyernv taureandyernv commented Oct 8, 2024

We are adding:

  • SDK Manger to the installation docs
  • SDK Manager as the preferred windows option
  • Updating Colab install links
  • Added CUDA 12.5 as a valid CUDA install options
  • update the CUDA verbiage around 12.5

@taureandyernv taureandyernv requested a review from a team as a code owner October 8, 2024 18:33
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 3, 2025 1:36am

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4fdcb5d
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/67a01d67792ef70008a74183
😎 Deploy Preview https://deploy-preview-547--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +29 to 32
- [SDK Manager](#wsl2-sdkm)
- [Conda](#wsl2-conda)
- [Docker](#wsl2-docker)
- [pip](#wsl2-pip)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this below pip? I think we should keep the order "Conda, Docker, pip, SDK Manager" to match the above.

Suggested change
- [SDK Manager](#wsl2-sdkm)
- [Conda](#wsl2-conda)
- [Docker](#wsl2-docker)
- [pip](#wsl2-pip)
- [Conda](#wsl2-conda)
- [Docker](#wsl2-docker)
- [pip](#wsl2-pip)
- [SDK Manager](#wsl2-sdkm)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should reorder this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taureandyernv could you please include this change?

It also lines up with the outline above it and the actual layout in the text below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taureandyernv let me know that @aravenel wants this at the top. I will defer to that decision.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better understand, met with Taurean and Alex today

From that meeting, Taurean clarified that Windows users are primarily looking for a GUI installer, which this meets. Hence promoting this first for the Windows case

The Linux use case is intended to remain the same

Now with a better understanding, agree this is reasonable

Co-authored-by: Bradley Dice <[email protected]>
taureandyernv and others added 6 commits October 9, 2024 12:38
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few open conversations from my last review pass. Please take a look at those before requesting a re-review.

https://github.com/rapidsai/docs/pull/547/files#r1792563333
https://github.com/rapidsai/docs/pull/547/files#r1792564184

taureandyernv and others added 2 commits October 9, 2024 13:58
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Comment on lines +29 to 32
- [SDK Manager](#wsl2-sdkm)
- [Conda](#wsl2-conda)
- [Docker](#wsl2-docker)
- [pip](#wsl2-pip)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should reorder this.

taureandyernv and others added 5 commits December 17, 2024 14:57
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
install/index.md Outdated
```
This will install and start Ubuntu in your Windows host system using WSL2. Make your **sudo** password memorable as you will need it in the next two steps.

4. Install and run SDK Manager inside Ubuntu by pasting this into your command line. You will have to enter the sudo password you created when you installed Ubuntu and also change folder location to match your home directory in Windows (if you don't know it, open PowerShell, type `$HOME`, and hit enter).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions like this are difficult for users. We ask them to "paste" but this command is not paste-able because it has placeholders like [YOUR HOME DIRECTORY ON WINDOWS].

Copy link
Contributor

@bdice bdice Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the $HOME directory you get from PowerShell isn't the same format as what the user needs for the Ubuntu WSL mount. The user has to recognize how to navigate this discrepancy.

What if we proposed something like:

cd "$(wslpath -au "$(cmd.exe /c 'echo %USERPROFILE%')")/Downloads"

For me, this navigates directly to /mnt/c/Users/bdice/Downloads. It may require some alterations for usernames with spaces in them, though. edit: I think my updated command is safe now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taureandyernv had some trouble making this work. Taurean, can you please share the output you got here for posterity?

taureandyernv and others added 2 commits January 27, 2025 13:50
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Taurean! 🙏

Can you please include Bradley's change linked below?

xref: #547 (comment)

@jakirkham
Copy link
Member

Tried to look at the preview, but got this error with the page

Screenshot 2025-01-31 at 12 25 02 PM

Is anyone else seeing this? Is there something I should be doing differently to load the preview?

@exactlyallan
Copy link
Member

Tried to look at the preview, but got this error with the page

Try signing off of VPN

@jakirkham
Copy link
Member

Thanks Allan! 🙏

Works like a charm 😄

Screenshot 2025-01-31 at 12 33 17 PM

@bdice bdice merged commit 9415a51 into rapidsai:main Feb 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants