-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDK Manager and updated CUDA install options #547
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
- [SDK Manager](#wsl2-sdkm) | ||
- [Conda](#wsl2-conda) | ||
- [Docker](#wsl2-docker) | ||
- [pip](#wsl2-pip) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this below pip? I think we should keep the order "Conda, Docker, pip, SDK Manager" to match the above.
- [SDK Manager](#wsl2-sdkm) | |
- [Conda](#wsl2-conda) | |
- [Docker](#wsl2-docker) | |
- [pip](#wsl2-pip) | |
- [Conda](#wsl2-conda) | |
- [Docker](#wsl2-docker) | |
- [pip](#wsl2-pip) | |
- [SDK Manager](#wsl2-sdkm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should reorder this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taureandyernv could you please include this change?
It also lines up with the outline above it and the actual layout in the text below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taureandyernv let me know that @aravenel wants this at the top. I will defer to that decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To better understand, met with Taurean and Alex today
From that meeting, Taurean clarified that Windows users are primarily looking for a GUI installer, which this meets. Hence promoting this first for the Windows case
The Linux use case is intended to remain the same
Now with a better understanding, agree this is reasonable
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few open conversations from my last review pass. Please take a look at those before requesting a re-review.
https://github.com/rapidsai/docs/pull/547/files#r1792563333
https://github.com/rapidsai/docs/pull/547/files#r1792564184
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
- [SDK Manager](#wsl2-sdkm) | ||
- [Conda](#wsl2-conda) | ||
- [Docker](#wsl2-docker) | ||
- [pip](#wsl2-pip) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should reorder this.
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
install/index.md
Outdated
``` | ||
This will install and start Ubuntu in your Windows host system using WSL2. Make your **sudo** password memorable as you will need it in the next two steps. | ||
|
||
4. Install and run SDK Manager inside Ubuntu by pasting this into your command line. You will have to enter the sudo password you created when you installed Ubuntu and also change folder location to match your home directory in Windows (if you don't know it, open PowerShell, type `$HOME`, and hit enter). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions like this are difficult for users. We ask them to "paste" but this command is not paste-able because it has placeholders like [YOUR HOME DIRECTORY ON WINDOWS]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the $HOME
directory you get from PowerShell isn't the same format as what the user needs for the Ubuntu WSL mount. The user has to recognize how to navigate this discrepancy.
What if we proposed something like:
cd "$(wslpath -au "$(cmd.exe /c 'echo %USERPROFILE%')")/Downloads"
For me, this navigates directly to /mnt/c/Users/bdice/Downloads
. It may require some alterations for usernames with spaces in them, though. edit: I think my updated command is safe now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taureandyernv had some trouble making this work. Taurean, can you please share the output you got here for posterity?
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try signing off of VPN |
Co-authored-by: jakirkham <[email protected]>
We are adding: