Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention old source_file argument still works #1369

Closed
wants to merge 1 commit into from
Closed

mention old source_file argument still works #1369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@
+ For `lint_dir()` and `lint_package()`, `...` is now the 2nd argument, where earlier this was `relative_path`
* Argument `source_file` to exported functions `with_id()` and `ids_with_token()` has been renamed to
`source_expression` to better reflect that this argument is typically the output of `get_source_expressions()`.
It has also been renamed as the argument of the now-private functional versions of many linters, which has no direct
effect on packages importing lintr, but is mentioned in case custom linters imitating `lintr` style have also
adopted the `source_file` naming and want to adapt to keep in sync.
For now, `source_file` can still be used (with warning). It has also been renamed as the argument of the now-private
functional versions of many linters, which has no direct effect on packages importing lintr, but is mentioned in case
custom linters imitating `lintr` style have also adopted the `source_file` naming and want to adapt to keep in sync.
* Deprecated `with_defaults()` in favor of `linters_with_defaults()`, and add `modify_defaults()` which is intended to be used
more generally to modify (i.e., extend, trim, and/or update) a list of defaults. Note that the argument corresponding to
`with_defaults()`'s `default=` is called `defaults=` (i.e., pluralized) in both of these, and that usage like
Expand Down