Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mention old source_file argument still works #1369

Closed
wants to merge 1 commit into from
Closed

mention old source_file argument still works #1369

wants to merge 1 commit into from

Conversation

MichaelChirico
Copy link
Collaborator

No description provided.

@AshesITR
Copy link
Collaborator

AshesITR commented Jun 6, 2022

huh? Isn't the argument name of the linter closure simply ignored because we provide it positionally?

@MichaelChirico
Copy link
Collaborator Author

Yes; this is referring to the arguments to with_id() and ids_with_token()

@MichaelChirico
Copy link
Collaborator Author

Just merging this into #1370 instead

@MichaelChirico MichaelChirico deleted the MichaelChirico-patch-3 branch June 7, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @AshesITR