Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codestarts: Add Entity annotation to Kotlin all-open #36638

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Codestarts: Add Entity annotation to Kotlin all-open #36638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/src/main/asciidoc/kotlin.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
we have specified that classes annotated with `jakarta.ws.rs.Path` should not be `final`.

If your application contains Kotlin classes annotated with `jakarta.enterprise.context.ApplicationScoped`
for example, then `<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>` needs to be added as well. Same goes for any class that needs to have a dynamic proxy created at runtime.
for example, then `<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>` needs to be added as well. Same goes for any class that needs to have a dynamic proxy created at runtime, like a JPA Entity class.

Check warning on line 177 in docs/src/main/asciidoc/kotlin.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'needs to'.

Raw Output:
{"message": "[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'needs to'.", "location": {"path": "docs/src/main/asciidoc/kotlin.adoc", "range": {"start": {"line": 177, "column": 103}}}, "severity": "INFO"}

Check warning on line 177 in docs/src/main/asciidoc/kotlin.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.TermsSuggestions] Depending on the context, consider using 'because' or 'while' rather than 'as'.

Raw Output:
{"message": "[Quarkus.TermsSuggestions] Depending on the context, consider using 'because' or 'while' rather than 'as'.", "location": {"path": "docs/src/main/asciidoc/kotlin.adoc", "range": {"start": {"line": 177, "column": 121}}}, "severity": "INFO"}

Future versions of Quarkus will configure the Kotlin compiler plugin in a way that will make it unnecessary to alter this configuration.

Expand Down Expand Up @@ -228,6 +228,7 @@
allOpen { // <2>
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down Expand Up @@ -296,6 +297,7 @@
allOpen { // <2>
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down
2 changes: 2 additions & 0 deletions ...resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/kotlin/build.tpl.qute.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ allOpen {
{#if quarkus.platform.version.startsWith("2.") or quarkus.platform.version.startsWith("1.")}
annotation("javax.ws.rs.Path")
annotation("javax.enterprise.context.ApplicationScoped")
annotation("javax.persistence.Entity")
{#else}
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
{/if}
annotation("io.quarkus.test.junit.QuarkusTest")
}
Expand Down
2 changes: 2 additions & 0 deletions ...tarts/src/main/resources/codestarts/quarkus/buildtool/gradle/kotlin/build.tpl.qute.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ allOpen {
{#if quarkus.platform.version.startsWith("2.") or quarkus.platform.version.startsWith("1.")}
annotation("javax.ws.rs.Path")
annotation("javax.enterprise.context.ApplicationScoped")
annotation("javax.persistence.Entity")
{#else}
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
{/if}
annotation("io.quarkus.test.junit.QuarkusTest")
}
Expand Down
2 changes: 2 additions & 0 deletions ...-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/kotlin/pom.tpl.qute.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@
{#if quarkus.platform.version.startsWith("2.") or quarkus.platform.version.startsWith("1.")}
<option>all-open:annotation=javax.ws.rs.Path</option>
<option>all-open:annotation=javax.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=javax.persistence.Entity</option>
{#else}
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
{/if}
<option>all-open:annotation=io.quarkus.test.junit.QuarkusTest</option>
</pluginOptions>
Expand Down
1 change: 1 addition & 0 deletions integration-tests/gradle/src/main/resources/bean-in-testsources-project/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ version '1.0.0-SNAPSHOT'
allOpen {
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down
1 change: 1 addition & 0 deletions integration-tests/gradle/src/main/resources/conditional-dependencies-kotlin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ java {
allOpen {
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down
1 change: 1 addition & 0 deletions integration-tests/gradle/src/main/resources/kotlin-grpc-project/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ version '1.0.0-SNAPSHOT'
allOpen {
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down
1 change: 1 addition & 0 deletions integration-tests/gradle/src/main/resources/multi-module-kotlin-project/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dependencies {
allOpen {
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down
1 change: 1 addition & 0 deletions integration-tests/gradle/src/main/resources/multi-source-project/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ version '1.0.0-SNAPSHOT'
allOpen {
annotation("jakarta.ws.rs.Path")
annotation("jakarta.enterprise.context.ApplicationScoped")
annotation("jakarta.persistence.Entity")
annotation("io.quarkus.test.junit.QuarkusTest")
}

Expand Down
1 change: 1 addition & 0 deletions integration-tests/hibernate-reactive-panache-kotlin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@
</compilerPlugins>
<pluginOptions>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
</pluginOptions>
</configuration>
</plugin>
Expand Down
1 change: 1 addition & 0 deletions integration-tests/kotlin/src/test/resources/projects/classic-kotlin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
<!-- Each annotation is placed on its own line -->
<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
</pluginOptions>
</configuration>
<dependencies>
Expand Down
1 change: 1 addition & 0 deletions ...ration-tests/kotlin/src/test/resources/projects/external-reloadable-artifacts/app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
<!-- Each annotation is placed on its own line -->
<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
</pluginOptions>
</configuration>
<dependencies>
Expand Down
1 change: 1 addition & 0 deletions integration-tests/kotlin/src/test/resources/projects/kotlin-compiler-args/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
<!-- Each annotation is placed on its own line -->
<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
</pluginOptions>
<args>
<arg>-Xemit-jvm-type-annotations</arg>
Expand Down
1 change: 1 addition & 0 deletions integration-tests/logging-panache-kotlin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@
</compilerPlugins>
<pluginOptions>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
</pluginOptions>
</configuration>
</plugin>
Expand Down
1 change: 1 addition & 0 deletions integration-tests/resteasy-reactive-kotlin/prod-mode/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
<pluginOptions>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
<option>all-open:annotation=io.quarkus.test.junit.QuarkusTest</option>
</pluginOptions>
</configuration>
Expand Down
1 change: 1 addition & 0 deletions integration-tests/resteasy-reactive-kotlin/standard/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@
<pluginOptions>
<option>all-open:annotation=jakarta.ws.rs.Path</option>
<option>all-open:annotation=jakarta.enterprise.context.ApplicationScoped</option>
<option>all-open:annotation=jakarta.persistence.Entity</option>
<option>all-open:annotation=io.quarkus.test.junit.QuarkusTest</option>
</pluginOptions>
</configuration>
Expand Down
Loading