-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codestarts: Add Entity annotation to Kotlin all-open #36638
Conversation
@gsmet Since I'm not as familiar with the codebase I essentially did a search for |
This comment has been minimized.
This comment has been minimized.
70cf847
to
b55331f
Compare
🙈 The PR is closed and the preview is expired. |
Failing Jobs - Building b55331f
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx-http/deployment
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 364 more 📦 extensions/vertx-http/deployment✖
⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
✖
✖
⚙️ Native Tests - Messaging1 #- Failing: integration-tests/kafka-oauth-keycloak
📦 integration-tests/kafka-oauth-keycloak✖ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm surprised we don't have to update the snapshots but tests are green so it should be good.
@gsmet should I investigate why some of the build failures happened? It seems you merged this already, though. |
@edeandrea no, we have a lot of flakiness lately, I'm making (very) slow progress to stabilize things but it's like playing whack-a-mole... |
The kotlin allopen plugin needs to be configured for entity classes when using panache.
This is a replacement for #36584
I also submitted quarkusio/quarkus-quickstarts#1343 because that fails with this error if not done: