Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python <3.11 #633

Merged
merged 11 commits into from
Jan 27, 2025
Merged

Drop support for Python <3.11 #633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8faf3d3
Upgrade ci to 3.13
mraspaud Nov 26, 2024
ebe1882
Fix min python version
mraspaud Jan 21, 2025
2640a8e
Address mypy errors
mraspaud Jan 21, 2025
6df6deb
Update rtd environment, os and mamba-forge versions
mraspaud Jan 21, 2025
2e303de
Addressing reviewer comments
mraspaud Jan 22, 2025
edc9772
Ignore arg-type errors for hashing numpy arrays
mraspaud Jan 24, 2025
54f8729
Overhaul wheel building
djhoese Jan 24, 2025
68839d3
Merge branch 'main' into support-3.13
djhoese Jan 24, 2025
7ea9d3a
Skip wheel tests on macos arm64 until pykdtree bundles libomp
djhoese Jan 24, 2025
9570b68
Fix artifact download multiple in wheel building
djhoese Jan 24, 2025
eb37fa0
Reenable wheel tests for mac arm
djhoese Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
fail-fast: true
matrix:
os: ["windows-latest", "ubuntu-latest", "macos-latest"]
python-version: ["3.9", "3.11", "3.12"]
python-version: ["3.11", "3.12", "3.13"]
experimental: [false]
include:
- python-version: "3.12"
- python-version: "3.13"
os: "ubuntu-latest"
experimental: true

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ convention = "google"
max-complexity = 10

[tool.mypy]
python_version = "3.9"
python_version = "3.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy should do checks based on the oldest supported version of python. So 3.11 in this case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t know that, fixed, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, now mypy is complaining again…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add type ignores for those lines. It is either numpy or the typeshed type definitions for the standard library's hash stuff that doesn't understand that numpy arrays support the buffer interface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, hopefully

# See https://github.com/python/mypy/issues/12286 for automatic multi-platform support
platform = "linux"
# platform = win32
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
packages=find_packages(),
package_data={'pyresample.test': ['test_files/*']},
include_package_data=True,
python_requires='>=3.9',
python_requires='>=3.10',
mraspaud marked this conversation as resolved.
Show resolved Hide resolved
setup_requires=['setuptools>=3.2'],
install_requires=requirements,
extras_require=extras_require,
Expand Down
Loading