-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python <3.11 #633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 93.96% 93.97% +0.01%
==========================================
Files 86 86
Lines 13546 13536 -10
==========================================
- Hits 12728 12721 -7
+ Misses 818 815 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ok so mypy is failing with
anyone knows what this is about? |
I think I've misused the type For the second error, change the import to |
pyproject.toml
Outdated
@@ -22,7 +22,7 @@ convention = "google" | |||
max-complexity = 10 | |||
|
|||
[tool.mypy] | |||
python_version = "3.9" | |||
python_version = "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy should do checks based on the oldest supported version of python. So 3.11 in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t know that, fixed, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, now mypy is complaining again…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add type ignores for those lines. It is either numpy or the typeshed type definitions for the standard library's hash stuff that doesn't understand that numpy arrays support the buffer interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, hopefully
Now there is a segfault when building wheels on aarch 64, should I try updating the ubuntu version? |
To be clear it is failing to test the wheels. The building of the wheel seems fine. I wonder, if you haven't already, if we can adopt the changes made here: |
Oh I think we're going to need storpipfugl/pykdtree#136 merged and released so we have a pykdtree ARM wheel with openmp available. Let me see if I can verify openmp linked in those wheels. |
This PR adds support for python 3.13. This was triggered by the rebuild of pyresample for 3.13 in conda forge.