Global Caravan handling GUI #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really cool. But we will need a button next to each caravan that directly opens the GUI. Also, what is the purpose of "key" column? |
|
What is the effect of "Caravan Organizer" hotkey? |
|
So currently: if you click on the "key" column it opens the caravan GUI (So Maybe it should look like an button?). It will definitely not print some integers in a more developed version However if you have a caravan open, you can also transfer items to and from the inventory of the caravan, even if its out of reach. The effect of the caravan organizer hotkey is that it opens a list every caravan, not just the ones connected to the selected outpost. |
|
So maybe ditching the global UI is in option, but it might still be useful for routine checks to see if you accidentely broke any of your caravans somewhere (state starving or state 'not automated') |
|
I have a solution for the inventory teleports. Once the PR is merged I will implement it. |
TheGoesen
force-pushed
the
caravan_overview_2.1.12
branch
from
5e0ef9b to
5134378
Compare
|
Ok that took a while to stop it from misbehaving... |
TheGoesen
changed the title
|
Oh and i have changed the text from 'Goto Caravan' to 'Open Caravan' but the screenshots are still wrong. Tired.... |
list by outpost scrollpane
TheGoesen
force-pushed
the
caravan_overview_2.1.12
branch
from
ea8ab76 to
81c0ffa
Compare
|
Wow, great effort on this. I believe this is the most high-effort PR we've had. I'll add some commits on your branch to improve the GUI style. |
|
is this done or what? |
|
from my perspective this can be merged, @notnotmelon do you want to do more refactoring, should i make changes? |
|
This needs more work on the graphics/styling side. It's one of my top priorities! |
notnotmelon
added a commit
that referenced
this pull request
Apr 15, 2024
* Frozen (#240) * make smart farms flora possitive * version and changelog * fix that collectors mk02-mk04 didnt get reset fixes pyanodon/pybugreports#461 * i blame theros ass * Smart farm fixes * pyanodon/pybugreports#458 * TURD balance & migrations * Fixed that subcritical-water-01 was not localised when pyAE is missing * Fixed that the alpha dingrits from dingrit turd path 1 could not be used as modules inside the reproductive complex. * Energy drink qol improvements * Fixed several bugs involved with biofluid vessel underground pipes * Fixed several bugs involved with biofluid vessel underground pipes * remove print statements * Reduce earlygame manual wood requirement grind. --------- Co-authored-by: kingarthur91 <[email protected]> * Fixed returned cages (#235) * Add files via upload * Fixed returned cages * Fixed returned cages * Fixed returned cages * Returned cages fixed * Fixed cage return * Global Caravan handling GUI (#222) * list of clickables everything is broken though * click opens the thing * moved to a new file-> todo prevent item stealing list by outpost scrollpane * outpost gui * status icon * less loc * new state idle * pasting untested stuff from chatgpt * ho * more stuff that will certainly work nocap * connected gui works * lets try this migrations thingy * fixed the migration * use the migration * fixed the close button... * cleanup code a bit * fixed the esc key * localization * localization * ship it * new rule I like open better * wuuups * I broke esc again... * Apply pyanodon code formatting standard * Remove references to stdlib functions as part of an ongoing effort to remove stdlib. * Streamline the amount of code needed to handle GUI closing events * Make the GUI expand to the container instead of having a hardcoded size * Improve the relative GUI type guessing algorithm * Move hotkey based GUI to pycodex and add a camera * Add more buttons and finalize styling --------- Co-authored-by: notnotmelon <[email protected]> * Add a rename button to the original caravan GUI * Add some randomly generated placeholder names for caravans. --------- Co-authored-by: kingarthur91 <[email protected]> Co-authored-by: Wisey <[email protected]> Co-authored-by: TheGoesen <[email protected]>
|
Merged and uploaded to the mod portal. Thanks again! |
|
Here is the final version after my styling: |
|
Poggies very cool thanks :) need to boot the game up again ;) |
notnotmelon
added a commit
that referenced
this pull request
May 17, 2024
* Frozen (#242) * Frozen (#240) * make smart farms flora possitive * version and changelog * fix that collectors mk02-mk04 didnt get reset fixes pyanodon/pybugreports#461 * i blame theros ass * Smart farm fixes * pyanodon/pybugreports#458 * TURD balance & migrations * Fixed that subcritical-water-01 was not localised when pyAE is missing * Fixed that the alpha dingrits from dingrit turd path 1 could not be used as modules inside the reproductive complex. * Energy drink qol improvements * Fixed several bugs involved with biofluid vessel underground pipes * Fixed several bugs involved with biofluid vessel underground pipes * remove print statements * Reduce earlygame manual wood requirement grind. --------- Co-authored-by: kingarthur91 <[email protected]> * Fixed returned cages (#235) * Add files via upload * Fixed returned cages * Fixed returned cages * Fixed returned cages * Returned cages fixed * Fixed cage return * Global Caravan handling GUI (#222) * list of clickables everything is broken though * click opens the thing * moved to a new file-> todo prevent item stealing list by outpost scrollpane * outpost gui * status icon * less loc * new state idle * pasting untested stuff from chatgpt * ho * more stuff that will certainly work nocap * connected gui works * lets try this migrations thingy * fixed the migration * use the migration * fixed the close button... * cleanup code a bit * fixed the esc key * localization * localization * ship it * new rule I like open better * wuuups * I broke esc again... * Apply pyanodon code formatting standard * Remove references to stdlib functions as part of an ongoing effort to remove stdlib. * Streamline the amount of code needed to handle GUI closing events * Make the GUI expand to the container instead of having a hardcoded size * Improve the relative GUI type guessing algorithm * Move hotkey based GUI to pycodex and add a camera * Add more buttons and finalize styling --------- Co-authored-by: notnotmelon <[email protected]> * Add a rename button to the original caravan GUI * Add some randomly generated placeholder names for caravans. --------- Co-authored-by: kingarthur91 <[email protected]> Co-authored-by: Wisey <[email protected]> Co-authored-by: TheGoesen <[email protected]> * Fix vonix cages issue introduced in the PR yesterday * Fixed unknown key error in the new caravan GUI * Day 1 patch for caravan GUI * pyanodon/pybugreports#469 * pyanodon/pybugreports#471 * Add a searchbar to the caravan global gui * Removed the incompatibility with omnimatter wood. * Buffed korlex path 2 * Removed references to nauvis in the locale * Removed references to nauvis in the locale * Buffed fawogae module breeding * Update luatest to include the frozen branch * Moved the ralesia turd from py4 to chem science. Also changed the text description on path 3. * Fix caravan copypast * nevermind this causes issues * increase version number * Fixed that nexelit ore had broken graphics in low-resolution mode. * Added compatibility between caravans and the remote configuration mod * path_resolution_modifier for caravans * Actually, lets only do this for aerials * added tier markers to rennea and arum seeds * 10X improvement for biofluid UPS * Increase version number --------- Co-authored-by: kingarthur91 <[email protected]> Co-authored-by: Wisey <[email protected]> Co-authored-by: TheGoesen <[email protected]>
notnotmelon
added a commit
that referenced
this pull request
May 28, 2024
* Frozen (#242) * Frozen (#240) * make smart farms flora possitive * version and changelog * fix that collectors mk02-mk04 didnt get reset fixes pyanodon/pybugreports#461 * i blame theros ass * Smart farm fixes * pyanodon/pybugreports#458 * TURD balance & migrations * Fixed that subcritical-water-01 was not localised when pyAE is missing * Fixed that the alpha dingrits from dingrit turd path 1 could not be used as modules inside the reproductive complex. * Energy drink qol improvements * Fixed several bugs involved with biofluid vessel underground pipes * Fixed several bugs involved with biofluid vessel underground pipes * remove print statements * Reduce earlygame manual wood requirement grind. --------- Co-authored-by: kingarthur91 <[email protected]> * Fixed returned cages (#235) * Add files via upload * Fixed returned cages * Fixed returned cages * Fixed returned cages * Returned cages fixed * Fixed cage return * Global Caravan handling GUI (#222) * list of clickables everything is broken though * click opens the thing * moved to a new file-> todo prevent item stealing list by outpost scrollpane * outpost gui * status icon * less loc * new state idle * pasting untested stuff from chatgpt * ho * more stuff that will certainly work nocap * connected gui works * lets try this migrations thingy * fixed the migration * use the migration * fixed the close button... * cleanup code a bit * fixed the esc key * localization * localization * ship it * new rule I like open better * wuuups * I broke esc again... * Apply pyanodon code formatting standard * Remove references to stdlib functions as part of an ongoing effort to remove stdlib. * Streamline the amount of code needed to handle GUI closing events * Make the GUI expand to the container instead of having a hardcoded size * Improve the relative GUI type guessing algorithm * Move hotkey based GUI to pycodex and add a camera * Add more buttons and finalize styling --------- Co-authored-by: notnotmelon <[email protected]> * Add a rename button to the original caravan GUI * Add some randomly generated placeholder names for caravans. --------- Co-authored-by: kingarthur91 <[email protected]> Co-authored-by: Wisey <[email protected]> Co-authored-by: TheGoesen <[email protected]> * Fix vonix cages issue introduced in the PR yesterday * Fixed unknown key error in the new caravan GUI * Day 1 patch for caravan GUI * pyanodon/pybugreports#469 * pyanodon/pybugreports#471 * Add a searchbar to the caravan global gui * Removed the incompatibility with omnimatter wood. * Buffed korlex path 2 * Removed references to nauvis in the locale * Removed references to nauvis in the locale * Buffed fawogae module breeding * Update luatest to include the frozen branch * Moved the ralesia turd from py4 to chem science. Also changed the text description on path 3. * Fix caravan copypast * nevermind this causes issues * increase version number * Fixed that nexelit ore had broken graphics in low-resolution mode. * Added compatibility between caravans and the remote configuration mod * path_resolution_modifier for caravans * Actually, lets only do this for aerials * added tier markers to rennea and arum seeds * 10X improvement for biofluid UPS * Increase version number * fix pks turd prod * CHANGELOG * fix pks turd prod (#244) * fix pks turd prod * CHANGELOG * pyanodon/pybugreports#399 * fix turd prod * fuck those space rocks --------- Co-authored-by: kingarthur91 <[email protected]> Co-authored-by: Wisey <[email protected]> Co-authored-by: TheGoesen <[email protected]> Co-authored-by: przemo1232 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I am currently working on some Gui additions to make life with caravans more tolerable. My first instinct was to just dump everything into a window, like the train overview or the universe explorer.
I quickly realized that that didnt actually address the most helpful thing needed, which I would describe as: given a full outpost, where is the caravan stuck thats supposed to empty it? So lets make a list when you click on an outpost, that gives you all caravans connected to it
That seems like a start...
So open questions.. what information can we actually put in the UI, how should it look like? The status light code is nice, but there is currently no light code for: 'caravan is just wandering around and not automated'... maybe turn this state to yellow?
Caravans could be connected to cargo wagon, so how handle cargo wagon to caravan? I like the idea of maybe adding something like the logistic button for caravans, but dont know if technically possible ..
Do you have suggestions?