Move to cw721 package #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CollectionInfo, ContractInfoResponse -> CollectionInfoResponse
…ration and keep legacy data for backward migration
- new query GetMinterOwnership and GetCreatorOwnership, deprecated Ownership - new execute UpdateMinterOwnership and UpdateCreatorOwnership, deprecate UpdateOwnership - dedicated stores for minter and creator, where creator usess by default cw_ownable singleton! - new migrate msg allowing to reset creator and minter - cleanup migration and split legacy part to dedicated functions - also make sure using decicated CREATOR and MINTER stores and NOT use cw_ownable::...
- move logic from cw721-base to cw721 - merge cw721-base and cw721-metadata-onchain into one, distinction is: `extension: T` where T for base contract is `type DefaultMetadataExtension = Option<Metadata>` - all logic now in default implementation for traits Cw721Execute and Cw721Query
taitruong
force-pushed
the
move_to_cw721_package
branch
11 times, most recently
from
753eca4 to
586df2a
Compare
taitruong
force-pushed
the
move_to_cw721_package
branch
from
586df2a to
6944bcb
Compare
taitruong
force-pushed
the
move_to_cw721_package
branch
from
c5c85b3 to
410d11e
Compare
shanev
approved these changes
Jun 27, 2024
JakeHartnell
approved these changes
Jun 27, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves code from contracts to cw721 package - as a preparation for PR #156 (
Major release v0.19: add CollectionInfo, RoyaltyInfo, updatable NFTs for creator, etc.).@jhernandezb, @JakeHartnell, all checks passed - except lint checker fails with
use of deprecated variant ...I have marked deprecated usages with #[allow(deprecated)], but linter still complaints.
Did the same in launchpad PR, but here it is all fine:
public-awesome/launchpad#668