Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default implementations for Cw721Execute and Cw721Query #135

Closed
taitruong opened this issue Aug 8, 2023 · 2 comments
Closed

Default implementations for Cw721Execute and Cw721Query #135

taitruong opened this issue Aug 8, 2023 · 2 comments

Comments

@taitruong
Copy link
Collaborator

Currently traits are implemented in cw721-base here:

https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/contracts/cw721-base/src/execute.rs#L132

https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/contracts/cw721-base/src/query.rs#L22

Any objection against moving this as default implementations traits in cw721 package? Here: https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/packages/cw721/src/traits.rs#L18

@taitruong
Copy link
Collaborator Author

@taitruong
Copy link
Collaborator Author

Done in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant