Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interference with coc-tsserver #277

Closed
wants to merge 2 commits into from
Closed

Fix interference with coc-tsserver #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
294d77f
Fix interference with coc-tsserver
knpwrs Jan 20, 2021
566e813
Repeat the coc-tsserver fix for JavaScript
knpwrs Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ftdetect/javascript.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
augroup PrettierFileDetect
autocmd BufNewFile,BufReadPost *.js,*jsx setfiletype javascript
autocmd BufNewFile,BufReadPost *.js setfiletype javascript
autocmd BufNewFile,BufReadPost *.jsx setfiletype javascript.jsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for choosing javascript.jsx. If not can you change it to javascriptreact

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only that the jsx / tsx types are more semantically correct. People can use jsx / tsx for more than just React.

augroup end
3 changes: 2 additions & 1 deletion ftdetect/typescript.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
augroup PrettierFileDetect
autocmd BufNewFile,BufReadPost *.ts,*.tsx setfiletype typescript
autocmd BufNewFile,BufReadPost *.ts setfiletype typescript
autocmd BufNewFile,BufReadPost *.tsx setfiletype typescript.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for choosing typescript.tsx. If not can you change it to typescriptreact

augroup end