Fix supporter being required when selecting default options in beatmap listing #11419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Aug 9, 2024
Comment on lines
12
to
18
| beforeAll(() => { | ||
| core.setCurrentUser(testCurrentUserJson); | ||
| }); | ||
|
|
||
| afterAll(() => { | ||
| core.setCurrentUser({ id: undefined }); | ||
| }); |
There was a problem hiding this comment.
actual problem was if tests that simulated having a user ran first and didn't have user_preferences set left it undefined when logging out
Doesn't affect normal logout as it reloads the whole page, but js tests unset the user to simulate logout
notbakaneko
force-pushed
the
feature/beatmapset-search-filter-default-reset
branch
from
831e61d to
7297a1b
Compare
nanaya
approved these changes
Aug 13, 2024
notbakaneko
deleted the
feature/beatmapset-search-filter-default-reset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check and normalize for default value when updating search filters instead of just the final url.
closes #10972