reset current user preferences when unsetting user.

Doesn't affect normal logout as it reloads the whole page, but js tests unset the user to simulate logout
ppy · Aug 9, 2024 · 831e61d · 831e61d
1 parent cf33e84
commit 831e61d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/resources/js/core/user/user-preferences.ts b/resources/js/core/user/user-preferences.ts
@@ -50,8 +50,8 @@ export default class UserPreferences {
   setUser(user?: CurrentUserJson) {
     this.user = user;
 
-    if (user != null && !this.updatingOptions) {
-      this.current = user?.user_preferences;
+    if (!this.updatingOptions) {
+      this.current = user?.user_preferences ?? structuredClone(defaultUserPreferencesJson);
     }
   }
 

diff --git a/tests/karma/beatmapset-search-filters.spec.ts b/tests/karma/beatmapset-search-filters.spec.ts
@@ -9,14 +9,6 @@ describe('BeatmapsetSearchFilters', () => {
   let subject: BeatmapsetSearchFilters;
 
   describe('.query', () => {
-    beforeAll(() => {
-      core.setCurrentUser(testCurrentUserJson);
-    });
-
-    afterAll(() => {
-      core.setCurrentUser({ id: undefined });
-    });
-
     beforeEach(() => {
       subject = new BeatmapsetSearchFilters('https://notarealdomain');
     });