Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIQ-5472: Make icon hoverable and clickable #142

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

atsunechka
Copy link
Collaborator

@atsunechka atsunechka commented Sep 27, 2024

image

Copy link
Contributor

@ivan-shtyrlyaev-nitka ivan-shtyrlyaev-nitka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this is wrong.
The main idea - combobox is an input (complex input with search and dropdown).
And this functionality is unlikely to be used and need a lot.

based on ticket requirement we need to add just cursor: pointer for the icon on hover, and we could do it right in agency IQ using :deep.
Nothing to change in vue-accessible-selects package

@ivan-shtyrlyaev-nitka
Copy link
Contributor

In my opinion this is wrong. The main idea - combobox is an input (complex input with search and dropdown). And this functionality is unlikely to be used and need a lot.

based on ticket requirement we need to add just cursor: pointer for the icon on hover, and we could do it right in agency IQ using :deep. Nothing to change in vue-accessible-selects package

per discussion with @atsunechka

since icon block is a sibling to input we cannot just remove pointer-events: none as propagation not working here because icon block is not a children of input block.

so we could just add a click handler to open menu. (and remove pointer-events: none). For screenreader users nothing will be changed (icon with click will be skipped as it doesn't have tabindex)

@atsunechka atsunechka changed the title AIQ-5472: Add iconIsClickable prop AIQ-5472: Make icon hoverable and clickable Sep 27, 2024
Copy link
Member

@cafloyd cafloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @atsunechka , and thanks for your help @ivan-shtyrlyaev-nitka !

@atsunechka - you'll also need to PR to the next branch since we also currently have an alpha version of this library.
(We still need to deprecate Vue 2 support in VAS and move the alpha (Vue 3) version to be the only version - I'll flag this issue for the FE team, it's one that has been brought up and we haven't dealt with yet.)

@atsunechka atsunechka merged commit b09031c into main Sep 30, 2024
5 checks passed
@atsunechka atsunechka deleted the bugfix/AIQ-5472 branch September 30, 2024 11:15
@atsunechka atsunechka restored the bugfix/AIQ-5472 branch September 30, 2024 12:19
@atsunechka atsunechka deleted the bugfix/AIQ-5472 branch September 30, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants