-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIQ-5472: Make icon hoverable and clickable #142
Conversation
atsunechka
commented
Sep 27, 2024
•
edited
Loading
edited
![image](https://private-user-images.githubusercontent.com/19799724/371548222-38fdf1d8-067a-494e-aaef-7232b3df52a6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTY2MTYsIm5iZiI6MTczOTQ5NjMxNiwicGF0aCI6Ii8xOTc5OTcyNC8zNzE1NDgyMjItMzhmZGYxZDgtMDY3YS00OTRlLWFhZWYtNzIzMmIzZGY1MmE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDAxMjUxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3NGJjOTgxYjJkNjFmZDA3NjU2YzViMmZiZTdmYzRhNjVkNTIyNjU4NjI2NTdmMmE5Zjc4N2YwNDM1MGFkNjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.eNMLIg4ebwMCz9abr6i3KyirDoUNriXUi_tIiAiPqHk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion this is wrong.
The main idea - combobox is an input (complex input with search and dropdown).
And this functionality is unlikely to be used and need a lot.
based on ticket requirement we need to add just cursor: pointer for the icon on hover, and we could do it right in agency IQ using :deep.
Nothing to change in vue-accessible-selects
package
per discussion with @atsunechka since icon block is a sibling to input we cannot just remove so we could just add a click handler to open menu. (and remove pointer-events: none). For screenreader users nothing will be changed (icon with click will be skipped as it doesn't have tabindex) |
df0d988
to
a9127d3
Compare
a9127d3
to
8be715d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @atsunechka , and thanks for your help @ivan-shtyrlyaev-nitka !
@atsunechka - you'll also need to PR to the next
branch since we also currently have an alpha version of this library.
(We still need to deprecate Vue 2 support in VAS and move the alpha (Vue 3) version to be the only version - I'll flag this issue for the FE team, it's one that has been brought up and we haven't dealt with yet.)