AIQ-5472: Review fixes

politico · Sep 27, 2024 · df0d988 · df0d988
1 parent 7cb35a1
commit df0d988
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/specs/SelectMulti.spec.ts b/specs/SelectMulti.spec.ts
@@ -110,7 +110,6 @@ describe('SelectMulti', () => {
 
 				const inputIconBlock = selectMulti.find('.combo-input-icon-block')
 
-				expect(inputIconBlock.element.tagName === 'BUTTON').toBeTruthy()
 				expect(inputIconBlock.classes('not-clickable')).toBe(false)
 			})
 		})

diff --git a/src/SelectMulti.vue b/src/SelectMulti.vue
@@ -429,7 +429,7 @@
 				</div>
 			</slot>
 			</div>
-			<component :is="iconIsClickable ? 'button' : 'div'" @click="iconIsClickable ? updateMenuState(iconIsClickable) : false" class="combo-input-icon-block" :class="{ 'not-clickable': !iconIsClickable }">
+			<div @click="iconIsClickable ? updateMenuState(iconIsClickable) : false" class="combo-input-icon-block" :class="{ 'not-clickable': !iconIsClickable }">
 				<template v-if="!loading">
 					<slot name="input-icon">
 						<svg class="combo-plus-icon" viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg" fill="currentColor">
@@ -444,7 +444,7 @@
 						<path d="M10.6353 4.71384C11.3212 7.36481 9.80202 10.0897 7.24202 10.8L7.55253 12C10.7525 11.1121 12.6516 7.70601 11.7941 4.39231L10.6353 4.71384Z" fill="currentColor"/>
 					</svg>
 				</template>
-			</component>
+			</div>
 		</div>
 	</div>
 </template>
diff --git a/src/styles/mixins.scss b/src/styles/mixins.scss
@@ -353,7 +353,7 @@ $spacer: 1.875rem; // 30px
 			top: 50%;
 			transform: translate(0, -50%);
 			right: math.div($spacer, 1.5);
-			border: none;
+			cursor: pointer;
 
 			&.not-clickable {
 				pointer-events: none;
-Original file line number
+Diff line change
@@ Expand Up / @@ -110,7 +110,6 @@ describe('SelectMulti', () => { @@
     				const inputIconBlock = selectMulti.find('.combo-input-icon-block')
-    				expect(inputIconBlock.element.tagName === 'BUTTON').toBeTruthy()
     				expect(inputIconBlock.classes('not-clickable')).toBe(false)
     			})
     		})
@@ Expand Down @@