Remove USBC WalletConnect integration #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fully support this but unfortunately don't have time to review it. 👍 |
martindsq
reviewed
Apr 4, 2024
Nos/Views/NoteTextEditor.swift
Outdated
| @@ -74,6 +75,7 @@ struct NoteTextEditor: View { | |||
| } | |||
|
|
|||
| private func insertMention(at offset: Int, author: Author) { | |||
| Log.error("test") | |||
There was a problem hiding this comment.
This sounds like a log you used while debugging
Nos/Models/RelaySubscription.swift
Outdated
| @@ -42,7 +41,7 @@ struct RelaySubscription: Identifiable { | |||
| ) { | |||
| self.filter = filter | |||
| self.relayAddress = relayAddress | |||
| self.id = (filter.id + "-" + relayAddress.absoluteString).sha256() | |||
| self.id = (filter.id + "-" + relayAddress.absoluteString).data(using: .utf8)!.sha256 | |||
There was a problem hiding this comment.
I know this could not fail in real life, but can you rewrite it without the !? We could just log that case so we can catch that unexpected case.
There was a problem hiding this comment.
I'm not sure why we are sha256ing this at all. It doesn't make it any more unique. I just removed that part.
martindsq
approved these changes
Apr 8, 2024
|
Always love to see −8,632 lines of code in a PR! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proof of concept USBC/Universal Ledger integration we built last year added a lot of heavy dependencies.
Removing this code sped up a clean build on my machine from 50 seconds to 30 seconds.
The USBC coin has not launched and actually their website (https://uled.io) redirects to another site now, so I think this is safe to remove for now.