Fix issue causing 'subscription id too long' messages #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindsq
requested changes
Apr 9, 2024
| @@ -42,7 +42,7 @@ struct RelaySubscription: Identifiable { | |||
| ) { | |||
| self.filter = filter | |||
| self.relayAddress = relayAddress | |||
| self.id = filter.id + "-" + relayAddress.absoluteString | |||
| self.id = (filter.id + "-" + relayAddress.absoluteString).data(using: .utf8)?.sha256 ?? "error" | |||
There was a problem hiding this comment.
I'm glad you spotted it. Do you mind adding a comment in the code linking to this PR? Just in case in the future we wonder the same thing.
martindsq
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this change here with the comment (and I quote) "I'm not sure why we are sha256ing this at all." It turns out that if you don't sha256 it the subscription IDs can become very long and relays will reject subscriptions with messages like: