Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No calls to throwing functions" warnings in unit tests #777

Closed
mplorentz opened this issue Jan 4, 2024 · 2 comments
Closed

Fix "No calls to throwing functions" warnings in unit tests #777

mplorentz opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
devx Work that will improve developer experience/velocity

Comments

@mplorentz
Copy link
Member

We have a number of No calls to throwing functions occur within 'try' expression warnings in our unit tests. This is because multiple Swift Packages that we import define functions with the same name, and depending on the order they are imported a different version can be used. What's worse is that the implementations aren't equivalent 😭 it caused a bug in the main target with event signing (can't find the details now) and this bug might sneak back in if we don't fix these warnings.

Screenshot 2024-01-04 at 10 09 59 AM

@mplorentz mplorentz added the devx Work that will improve developer experience/velocity label Jan 4, 2024
@mplorentz mplorentz moved this to Delivery Backlog in Verse: Nos Projects Jan 5, 2024
@joshuatbrown
Copy link
Contributor

@mplorentz I used to see these warnings, too, but I'm not any more, so I'm closing this. Maybe this was fixed when we removed some dependencies we no longer needed? Or maybe when someone just fixed them.

@github-project-automation github-project-automation bot moved this from Delivery Backlog to Done in Verse: Nos Projects Apr 22, 2024
@mplorentz
Copy link
Member Author

I think #987 might have fixed this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Work that will improve developer experience/velocity
Projects
Archived in project
Development

No branches or pull requests

2 participants