util: extend row format with checksum #42859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zyguan <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
Signed-off-by: zyguan <[email protected]>
|
/retest |
Signed-off-by: zyguan <[email protected]>
cfzjywxk
reviewed
Apr 7, 2023
| // - VER: version | ||
| // - E: has extra checksum | ||
| // - CHECKSUM | ||
| // - little-endian CRC32(IEEE) when hdr.ver = 0 (default) |
3AceShowHand
approved these changes
Apr 10, 2023
ti-chi-bot
added
status/LGT2
|
LGTM |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6f81089
|
ti-chi-bot
added
the
status/can-merge
This was referenced Apr 10, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #42747
Problem Summary: see #42747
What is changed and how it works?
Add checksum-related utilities in tidb.
Encoder.WithChecksumto enable/disable checksum.Encoder.Checksum()to calculate the checksum of input datums.Encoder.EncodeWithExtraChecksum()to append extra checksum to the row value. (the extra checksum is calculated byEncoder.Checksum())GetChecksum/GetExtraChecksumto access the checksum info encoded in the row value.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.