-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: reimplement row level checksum utilities #43141
Conversation
Signed-off-by: zyguan <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: zyguan <[email protected]>
Signed-off-by: zyguan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7cd304d
|
What problem does this PR solve?
Issue Number: ref #42747
Problem Summary:
We have implemented row level checksum utilities in #42859. However, it doesn't match the requirements for e2e checksum verification, because downstream consumers cannot calculate the checksum as tidb does. So, we reimplement checksum algorithm in this PR.
What is changed and how it works?
Check List
Tests
Side effects
The overhead of checksum calculation shall be fine.
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.