Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix e2e-examples in GitHub Action (#5333) #5334

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5333

What problem does this PR solve?

fix tls example in CI

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikechengwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from KanShiori and shonge October 16, 2023 02:39
@codecov-commenter
Copy link

Codecov Report

Merging #5334 (7221626) into release-1.5 (e9972aa) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #5334   +/-   ##
============================================
  Coverage        57.67%   57.68%           
============================================
  Files              254      254           
  Lines            30838    30838           
============================================
+ Hits             17786    17788    +2     
+ Misses           11314    11312    -2     
  Partials          1738     1738           
Flag Coverage Δ
unittest 57.68% <ø> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 8dae55b into pingcap:release-1.5 Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants