Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix e2e-examples in GitHub Action #5333

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Oct 16, 2023

What problem does this PR solve?

fix tls example in CI

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge October 16, 2023 02:13
@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 16, 2023
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

Merging #5333 (4efcdc6) into master (33ab46e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5333   +/-   ##
=======================================
  Coverage   57.67%   57.67%           
=======================================
  Files         252      252           
  Lines       30821    30821           
=======================================
  Hits        17775    17775           
  Misses      11301    11301           
  Partials     1745     1745           
Flag Coverage Δ
unittest 57.67% <ø> (ø)

@csuzhangxc csuzhangxc merged commit 94ed069 into pingcap:master Oct 16, 2023
@csuzhangxc csuzhangxc deleted the fix-e2e-example branch October 16, 2023 02:39
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5334.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.4: #5335.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants