CLI allows "disabling" total project threshold #288
Labels
Comments
kylewillmon
added
bug
|
This seems related to #287 (comment). There's no way to know if a threshold was actually disabled or not. |
louislang
added
medium priority
cd-work
added a commit
that referenced
this issue
Apr 29, 2022
Previously, when setting the project thresholds from the CLI, a value of `0` would automatically disable the specified threshold. This does not correctly represent the backend configuration, since some thresholds cannot be disabled and it is possible to have a threshold enabled with a value of `0`. To address both of these issues, an explicit `Disabled` option has been added to the interactive `set-thresholds` command, which allows controlling the `active` state of the threshold independently from its value. To ensure that the "Total Project" threshold is not disabled, a special case has been added which will inform the user that a value must be set for this threshold. Closes #288.
cd-work
added a commit
that referenced
this issue
May 2, 2022
Previously, when setting the project thresholds from the CLI, a value of `0` would automatically disable the specified threshold. This does not correctly represent the backend configuration, since some thresholds cannot be disabled and it is possible to have a threshold enabled with a value of `0`. To address both of these issues, an explicit `Disabled` option has been added to the interactive `set-thresholds` command, which allows controlling the `active` state of the threshold independently from its value. To ensure that the "Total Project" threshold is not disabled, a special case has been added which will inform the user that a value must be set for this threshold. Closes #288.
cd-work
added a commit
that referenced
this issue
May 3, 2022
Previously, when setting the project thresholds from the CLI, a value of `0` would automatically disable the specified threshold. This does not correctly represent the backend configuration, since some thresholds cannot be disabled and it is possible to have a threshold enabled with a value of `0`. To address both of these issues, an explicit `Disabled` option has been added to the interactive `set-thresholds` command, which allows controlling the `active` state of the threshold independently from its value. To ensure that the "Total Project" threshold is not disabled, a special case has been added which will inform the user that a value must be set for this threshold. Closes #288.
cd-work
added a commit
that referenced
this issue
May 3, 2022
Previously, when setting the project thresholds from the CLI, a value of `0` would automatically disable the specified threshold. This does not correctly represent the backend configuration, since some thresholds cannot be disabled and it is possible to have a threshold enabled with a value of `0`. To address both of these issues, an explicit `Disabled` option has been added to the interactive `set-thresholds` command, which allows controlling the `active` state of the threshold independently from its value. To ensure that the "Total Project" threshold is not disabled, a special case has been added which will inform the user that a value must be set for this threshold. Closes #288.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the
phylum project set-thresholdscommand, using a score of 0 (zero) for the "TOTAL PROJECT Threshold" claims that this is "disabling" the threshold:However, in the UI, there is no option to disable the total project threshold. The individual risk domains all have sliders next to them, but the total project threshold does not:
So this threshold is actually enabled with a value of 0
The text was updated successfully, but these errors were encountered: