Allow freely setting project thresholds #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If a non-breaking change is preferred, it would also be possible to create a separate method. However I've opted to fix things rather than duplicating it. |
Previously the `active` field of the thresholds struct was populated by checking whether the `threshold` was above `0` or not. However the `Total Project Threshold` can never be disabled and it is possible for other thresholds to be at `0` without being disabled too. To ensure a more accurate representation of the backend state, the `set_threshold` method instead takes a `Threshold` instance which can be populated fully by the consumer without any internal restrictions. See #288.
kylewillmon
approved these changes
Apr 28, 2022
cd-work
requested review from
a team and
DanielJoyce
and removed request for
a team
|
This isn't called in api, but may be in CLI, |
DanielJoyce
approved these changes
Apr 29, 2022
Yes, this is where it's called and what motivated this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
activefield of the thresholds struct was populated bychecking whether the
thresholdwas above0or not. However theTotal Project Thresholdcan never be disabled and it is possible forother thresholds to be at
0without being disabled too.To ensure a more accurate representation of the backend state, the
set_thresholdmethod instead takes aThresholdinstance which can bepopulated fully by the consumer without any internal restrictions.
See phylum-dev/cli#288.