Add explicit option to disable thresholds from CLI #329
Conversation
There was a problem hiding this comment.
Confirmed the expected behavior by building and testing locally. There is room for additional documentation to be added somewhere in the docs directory...but that may already be in progress by @furi0us333 in the brad/docs_v2 branch.
LGTM.
Previously, when setting the project thresholds from the CLI, a value of `0` would automatically disable the specified threshold. This does not correctly represent the backend configuration, since some thresholds cannot be disabled and it is possible to have a threshold enabled with a value of `0`. To address both of these issues, an explicit `Disabled` option has been added to the interactive `set-thresholds` command, which allows controlling the `active` state of the threshold independently from its value. To ensure that the "Total Project" threshold is not disabled, a special case has been added which will inform the user that a value must be set for this threshold. Closes #288.
Just for the future it would probably make sense to have some way to retrieve available thresholds and get information about the ability to enable/disable them. But since that hasn't been done before and knowledge about these thresholds is just hardcoded, I don't think it's justified to explore that in this PR. |
Previously, when setting the project thresholds from the CLI, a value of
0would automatically disable the specified threshold. This does notcorrectly represent the backend configuration, since some thresholds
cannot be disabled and it is possible to have a threshold enabled with a
value of
0.To address both of these issues, an explicit
Disabledoption has beenadded to the interactive
set-thresholdscommand, which allowscontrolling the
activestate of the threshold independently from itsvalue.
To ensure that the "Total Project" threshold is not disabled, a special
case has been added which will inform the user that a value must be set
for this threshold.
Closes #288.