Set the minWidth and the minHeight of the endPanel created for a box layout #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layout, so that an empty endPanel does not render the default number of pixels specified in Morph>>#minWidth and Morph>>#minHeight.
|
Thanks Koen. I kicked the build. |
|
@Ducasse Some tests failed, but I think the failures are not related to the changes in this PR. Who will solve the failures? |
|
No idea now for this test we can change the 143 into 144 or the inverse and get done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue pharo-project/pharo#15830. As described there, this PR:
minWidthof anendPanelin a horizontal box layoutminHeightof anendPanelin a vertical box layoutPlease apply this fix to Pharo 11 as well. Thank you!