-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the minWidth and the minHeight of the endPanel created for a box layout #1513
Set the minWidth and the minHeight of the endPanel created for a box layout #1513
Conversation
…layout, so that an empty endPanel does not render the default number of pixels specified in Morph>>#minWidth and Morph>>#minHeight.
… for the width of presenters do not make the test fail. Also use the same style of writing the assertions in the two tests.
The changes made two box layout tests fail, because of rounding errors on the width of the children of the box layout. I adapted the code to avoid rounding errors. Btw: does |
@estebanlm The tests are green except for one that does not seem to be related to the changes. Please review and merge. |
@estebanlm
The PR for Pharo 12 was #1507.
This is the PR to fix the same problem in Pharo 11.