Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lfe motion io topology #97

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Update lfe motion io topology #97

merged 5 commits into from
Jan 22, 2025

Conversation

c-tsoi
Copy link

@c-tsoi c-tsoi commented Jan 21, 2025

Description

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@c-tsoi c-tsoi requested review from NSLentz and joshc-slac January 21, 2025 23:48
@joshc-slac
Copy link

Looks great will approve when you get my PR in

@joshc-slac
Copy link

@NSLentz is it okay to merge your PR #96 in to master this PR does so implicitly

@joshc-slac
Copy link

I will approve, wait to merge upon Nicks ack

joshc-slac
joshc-slac previously approved these changes Jan 22, 2025
View reviewed changes
NSLentz
NSLentz approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was present for much of the testings and we checked the devices to make sure they still move. I am okay with proceeding with merging this code.

@NSLentz NSLentz merged commit 0ea3fe8 into pcdshub:master Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSLentz NSLentz NSLentz approved these changes

@joshc-slac joshc-slac joshc-slac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-tsoi @joshc-slac @NSLentz