Ensure that the "skipFinallyBlock" variable is set even if CatchBlock is null #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up commit for c773bf2:
Generate a
catch
block even ifthis.CatchClause
isnull
(and rethrow the exception in this case), to ensure theskipFinallyBlock
variable is set in every case, not only when the script has acatch
clause. This fixes the remaining issue of #85 where afinally
block would execute if the script only has atry-finally
block instead oftry-catch-finally
and the Exception is not catchable in JS.Notes:
catch (Exception ex)
clause. In theory, the CLR allows to throw anyobject
, nut justException
, so to be safe we might want to change the emit tocatch (object o)
and changeScriptEngine.CanCatchException(Exception)
to accept anobject
parameter.skipFinallyBlock
variable could be changed to use a temporary variable.Thanks!