Change the type of the exception variable to 'object' #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR addresses the two notes described in #90.
By changing the type of the exception variable in the
catch
clause fromException
toobject
, it is ensured that thefinally
block is also correctly skipped if objects are thrown that do not derive fromException
(which is possible in the CLR).Note: When a non-
Exception
object is thrown and the control flow enters code generated by the C# compiler, the thrown object is wrapped in aRuntimeWrappedException
so it can be caught by ancatch (Exception)
C# statement.However, even with this I think it is safer to catch
object
in the generated IL code, to ensure JSfinally
blocks are not executed in such a case.Additionally, the
skipFinallyBlock
variable is changed to a temporary variable.Thanks!