-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(no-std): enable no_std
support for op consensus rules
#13684
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,188 @@ | ||
//! Optimism beacon consensus rule set. | ||
#![cfg(feature = "std")] | ||
|
||
use alloc::sync::Arc; | ||
use std::time::SystemTime; | ||
|
||
use alloy_consensus::{BlockHeader, Header, EMPTY_OMMER_ROOT_HASH}; | ||
use alloy_eips::eip7840::BlobParams; | ||
use alloy_primitives::{B64, U256}; | ||
use reth_chainspec::EthereumHardforks; | ||
use reth_consensus::{ | ||
Consensus, ConsensusError, FullConsensus, HeaderValidator, PostExecutionInput, | ||
}; | ||
use reth_consensus_common::validation::{ | ||
validate_against_parent_4844, validate_against_parent_eip1559_base_fee, | ||
validate_against_parent_hash_number, validate_against_parent_timestamp, | ||
validate_body_against_header, validate_cancun_gas, validate_header_base_fee, | ||
validate_header_extra_data, validate_header_gas, validate_shanghai_withdrawals, | ||
}; | ||
use reth_optimism_chainspec::OpChainSpec; | ||
use reth_optimism_forks::OpHardforks; | ||
use reth_optimism_primitives::{OpBlock, OpBlockBody, OpPrimitives, OpReceipt}; | ||
use reth_primitives::{BlockWithSenders, GotExpected, SealedBlockFor, SealedHeader}; | ||
|
||
use crate::validate_block_post_execution; | ||
|
||
/// Optimism consensus implementation. | ||
/// | ||
/// Provides basic checks as outlined in the execution specs. | ||
#[derive(Debug, Clone, PartialEq, Eq)] | ||
pub struct OpBeaconConsensus { | ||
/// Configuration | ||
chain_spec: Arc<OpChainSpec>, | ||
} | ||
|
||
impl OpBeaconConsensus { | ||
/// Create a new instance of [`OpBeaconConsensus`] | ||
pub const fn new(chain_spec: Arc<OpChainSpec>) -> Self { | ||
Self { chain_spec } | ||
} | ||
} | ||
|
||
impl FullConsensus<OpPrimitives> for OpBeaconConsensus { | ||
fn validate_block_post_execution( | ||
&self, | ||
block: &BlockWithSenders<OpBlock>, | ||
input: PostExecutionInput<'_, OpReceipt>, | ||
) -> Result<(), ConsensusError> { | ||
validate_block_post_execution(block, &self.chain_spec, input.receipts) | ||
} | ||
} | ||
|
||
impl Consensus<Header, OpBlockBody> for OpBeaconConsensus { | ||
fn validate_body_against_header( | ||
&self, | ||
body: &OpBlockBody, | ||
header: &SealedHeader, | ||
) -> Result<(), ConsensusError> { | ||
validate_body_against_header(body, header.header()) | ||
} | ||
|
||
fn validate_block_pre_execution( | ||
&self, | ||
block: &SealedBlockFor<OpBlock>, | ||
) -> Result<(), ConsensusError> { | ||
// Check ommers hash | ||
let ommers_hash = block.body().calculate_ommers_root(); | ||
if block.ommers_hash != ommers_hash { | ||
return Err(ConsensusError::BodyOmmersHashDiff( | ||
GotExpected { got: ommers_hash, expected: block.ommers_hash }.into(), | ||
)) | ||
} | ||
|
||
// Check transaction root | ||
if let Err(error) = block.ensure_transaction_root_valid() { | ||
return Err(ConsensusError::BodyTransactionRootDiff(error.into())) | ||
} | ||
|
||
// EIP-4895: Beacon chain push withdrawals as operations | ||
if self.chain_spec.is_shanghai_active_at_timestamp(block.timestamp) { | ||
validate_shanghai_withdrawals(block)?; | ||
} | ||
|
||
if self.chain_spec.is_cancun_active_at_timestamp(block.timestamp) { | ||
validate_cancun_gas(block)?; | ||
} | ||
|
||
Ok(()) | ||
} | ||
} | ||
|
||
impl HeaderValidator for OpBeaconConsensus { | ||
fn validate_header(&self, header: &SealedHeader) -> Result<(), ConsensusError> { | ||
validate_header_gas(header.header())?; | ||
validate_header_base_fee(header.header(), &self.chain_spec) | ||
} | ||
|
||
fn validate_header_against_parent( | ||
&self, | ||
header: &SealedHeader, | ||
parent: &SealedHeader, | ||
) -> Result<(), ConsensusError> { | ||
validate_against_parent_hash_number(header.header(), parent)?; | ||
|
||
if self.chain_spec.is_bedrock_active_at_block(header.number) { | ||
validate_against_parent_timestamp(header.header(), parent.header())?; | ||
} | ||
|
||
// EIP1559 base fee validation | ||
// <https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/holocene/exec-engine.md#base-fee-computation> | ||
// > if Holocene is active in parent_header.timestamp, then the parameters from | ||
// > parent_header.extraData are used. | ||
if self.chain_spec.is_holocene_active_at_timestamp(parent.timestamp) { | ||
let header_base_fee = | ||
header.base_fee_per_gas().ok_or(ConsensusError::BaseFeeMissing)?; | ||
let expected_base_fee = self | ||
.chain_spec | ||
.decode_holocene_base_fee(parent, header.timestamp) | ||
.map_err(|_| ConsensusError::BaseFeeMissing)?; | ||
if expected_base_fee != header_base_fee { | ||
return Err(ConsensusError::BaseFeeDiff(GotExpected { | ||
expected: expected_base_fee, | ||
got: header_base_fee, | ||
})) | ||
} | ||
} else { | ||
validate_against_parent_eip1559_base_fee( | ||
header.header(), | ||
parent.header(), | ||
&self.chain_spec, | ||
)?; | ||
} | ||
|
||
// ensure that the blob gas fields for this block | ||
if self.chain_spec.is_cancun_active_at_timestamp(header.timestamp) { | ||
validate_against_parent_4844(header.header(), parent.header(), BlobParams::cancun())?; | ||
} | ||
|
||
Ok(()) | ||
} | ||
|
||
fn validate_header_with_total_difficulty( | ||
&self, | ||
header: &Header, | ||
_total_difficulty: U256, | ||
) -> Result<(), ConsensusError> { | ||
// with OP-stack Bedrock activation number determines when TTD (eth Merge) has been reached. | ||
let is_post_merge = self.chain_spec.is_bedrock_active_at_block(header.number); | ||
|
||
if is_post_merge { | ||
if header.nonce != B64::ZERO { | ||
return Err(ConsensusError::TheMergeNonceIsNotZero) | ||
} | ||
|
||
if header.ommers_hash != EMPTY_OMMER_ROOT_HASH { | ||
return Err(ConsensusError::TheMergeOmmerRootIsNotEmpty) | ||
} | ||
|
||
// Post-merge, the consensus layer is expected to perform checks such that the block | ||
// timestamp is a function of the slot. This is different from pre-merge, where blocks | ||
// are only allowed to be in the future (compared to the system's clock) by a certain | ||
// threshold. | ||
// | ||
// Block validation with respect to the parent should ensure that the block timestamp | ||
// is greater than its parent timestamp. | ||
|
||
// validate header extra data for all networks post merge | ||
validate_header_extra_data(header)?; | ||
|
||
// mixHash is used instead of difficulty inside EVM | ||
// https://eips.ethereum.org/EIPS/eip-4399#using-mixhash-field-instead-of-difficulty | ||
} else { | ||
// Check if timestamp is in the future. Clock can drift but this can be consensus issue. | ||
let present_timestamp = | ||
SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs(); | ||
|
||
if header.exceeds_allowed_future_timestamp(present_timestamp) { | ||
return Err(ConsensusError::TimestampIsInFuture { | ||
timestamp: header.timestamp, | ||
present_timestamp, | ||
}) | ||
} | ||
} | ||
|
||
Ok(()) | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can likely make this fully no-std if we do some prep first on these
reth/crates/optimism/consensus/Cargo.toml
Lines 22 to 25 in 28fde3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, the issue is
std::time::SystemTime
, wdym?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I found this now #13683 (comment)