Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-std): enable no_std support for op consensus rules #13684

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat(no-std): enable no_std support for op consensus rules #13684

merged 2 commits into from
Jan 6, 2025

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 6, 2025

Closes #13683.

@emhane emhane added A-consensus Related to the consensus engine A-dependencies Pull requests or issues that are about dependencies A-op-reth Related to Optimism and op-reth labels Jan 6, 2025
Rjected
Rjected requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, could we also add this to the .github/assets/check_wasm.sh script?
nvm, this is already not excluded from the check_wasm script

crates/optimism/consensus/src/validation.rs Show resolved Hide resolved
mattsse
mattsse requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want all of this to be fully no-std and should be doable if we do some prep first

ref #13686

crates/optimism/consensus/src/beacon.rs
@@ -0,0 +1,188 @@
//! Optimism beacon consensus rule set.

#![cfg(feature = "std")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can likely make this fully no-std if we do some prep first on these

reth/crates/optimism/consensus/Cargo.toml

Lines 22 to 25 in 28fde3f

reth-optimism-forks.workspace = true
reth-optimism-chainspec.workspace = true
# TODO: remove this after feature cleanup
reth-optimism-primitives = { workspace = true, features = ["serde"] }

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, the issue is std::time::SystemTime, wdym?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I found this now #13683 (comment)

@mattsse mattsse merged commit 89a93c5 into main Jan 6, 2025
43 checks passed
@mattsse mattsse deleted the emhane/op-consensus-no-std branch January 6, 2025 21:48
mattsse added a commit that referenced this pull request Jan 6, 2025
@mattsse
Revert "feat(no-std): enable no_std support for op consensus rules (#…
f6fc403 
…13684)"

This reverts commit 89a93c5.
@mattsse mattsse mentioned this pull request Jan 6, 2025
Merged
@mattsse
Copy link
Collaborator

mattsse commented Jan 6, 2025

sorry, force merged the wrong pr... see #13689
we still want this though

@emhane emhane restored the emhane/op-consensus-no-std branch January 6, 2025 23:47
@emhane
Copy link
Member Author

emhane commented Jan 6, 2025

cool, could we also add this to the .github/assets/check_wasm.sh script? nvm, this is already not excluded from the check_wasm script

yes, it's flaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

@Rjected Rjected Rjected requested changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-dependencies Pull requests or issues that are about dependencies A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no_std OP consensus rules
3 participants
@emhane @mattsse @Rjected