Write-ahead log for SSTable deletions #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi11dey
commented
Oct 21, 2024
Comment on lines
+232
to
234
| if (!readyToFinish) { | ||
| // TODO(wdey): refactor all of the trys | ||
| try (Refs closedRefs = refs; CompactionController closedController = controller) {} | ||
| } |
There was a problem hiding this comment.
this is unfortunate; we should do something like #549 (comment) as a follow up
zpear
reviewed
Oct 23, 2024
src/java/org/apache/cassandra/db/lifecycle/LifecycleTransaction.java
Outdated
Show resolved
Hide resolved
zpear
reviewed
Oct 23, 2024
| @@ -99,6 +101,7 @@ public boolean reduceScopeForLimitedSpace(long expectedSize) | |||
| * which are properly serialized. | |||
| * Caller is in charge of marking/unmarking the sstables as compacting. | |||
| */ | |||
| @SuppressWarnings("resource") // It is dangerous to close refs for a failed transaction | |||
There was a problem hiding this comment.
we should add a larger comment detailing the specifics of what we're trying to avoid/fix here
zpear
reviewed
Oct 23, 2024
src/java/com/palantir/cassandra/db/IColumnFamilyStoreValidator.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.