Enable using the write ahead log #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi11dey
changed the base branch from
palantir-cassandra-2.2.18
to
wdey/panic-on-non-delete
wi11dey
commented
Nov 7, 2024
Comment on lines
+226
to
232
| if (!readyToFinish) { | ||
| // TODO(wdey): refactor all of the trys | ||
| try (Refs closedRefs = refs; CompactionController closedController = controller) {} | ||
| } |
There was a problem hiding this comment.
same comment as #557 (comment)
|
Do you want to use safelogging here? |
|
an indentation level was removed in the outer try, no logging changes in this pr; best to click "Hide whitespace" for the diff |
wi11dey
force-pushed
the
wdey/panic-on-non-delete
branch
from
12d80d8 to
6199665
Compare
wi11dey
force-pushed
the
wdey/enable-wal
branch
from
a56912e to
9306689
Compare
wi11dey
changed the base branch from
wdey/panic-on-non-delete
to
palantir-cassandra-2.2.18
wi11dey
force-pushed
the
wdey/enable-wal
branch
from
2f3d625 to
aefb12e
Compare
zpear
reviewed
Nov 13, 2024
zpear
reviewed
Nov 13, 2024
src/java/org/apache/cassandra/db/compaction/CompactionTask.java
Outdated
Show resolved
Hide resolved
wi11dey
force-pushed
the
wdey/enable-wal
branch
from
d385c8a to
659a880
Compare
zpear
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.