Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM changes for more consistent positioning of menu. #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DOM changes for more consistent positioning of menu. #27

wants to merge 1 commit into from

Conversation

corwin-of-amber
Copy link
Contributor

This is related to #26, I will rebase it after this one is merged.

@corwin-of-amber
Copy link
Contributor Author

Ok seems that I am going to rebase this one on top of #26 instead of vice versa.

@corwin-of-amber
Copy link
Contributor Author

🍴

@andersevenrud
Copy link
Member

I think I might have to find an alternative to Codacy. It gets drunk way to often and produce some weird errors/warnings :P

@corwin-of-amber
Copy link
Contributor Author

I wonder if that have anything to do with my force-pushing all the time.

@andersevenrud
Copy link
Member

The weird thing is that it only triggers errors on the lines you've changed 😂

@corwin-of-amber
Copy link
Contributor Author

I think that is by design, it only checks the specific commit.
But definitely some other commits had single quotes in them and those were found ok...

@andersevenrud
Copy link
Member

I think I figured it out. Seems like Codacy does not read linter configurations from package.json 🤦‍♂️ I moved all the dotfile configuration there in pretty much all base libraries this week.

So I've disabled Codacy pull request checks, and instead moved over to CodeClimate which I use on some other stuff -- and I'll try to move everything there.

I'll see if closing and re-opening this triggers the correct integrations 🤔

@andersevenrud andersevenrud reopened this Jan 16, 2020
@andersevenrud andersevenrud reopened this Jan 16, 2020
@andersevenrud
Copy link
Member

Sorry if this is spamming you. Seems like the previous Codacy check won't go away 😂

@corwin-of-amber
Copy link
Contributor Author

Want me to make a fresh PR?

@corwin-of-amber corwin-of-amber mentioned this pull request Jan 23, 2020
Closed
@corwin-of-amber
Copy link
Contributor Author

corwin-of-amber commented Feb 1, 2020 •
edited
Loading

Hi, I rebased this fix so that it runs on Code Climate but now the config is borked...

@andersevenrud
Copy link
Member

andersevenrud commented Feb 1, 2020 •
edited
Loading

I've seen this in some other repos as well. Not quite sure why it happens as Codeclimate just uses the stylelint engine 🤔 But clearly it has something to do with dependencies for stylelint in particular, because eslint does not behave like this.

I'll try to contact support.

Edit Support link: gilbarbara/codeclimate-stylelint#38

@corwin-of-amber
More consistent positioning of menu.
77d09c0 
This is done by wrapping panel item content with a <div> and clamping
the context menu to it.
@corwin-of-amber
Copy link
Contributor Author

I forgot about this little PR, I have rebased it now and the CI seems to work!

@andersevenrud
Copy link
Member

I totally forgot as well! I'll have to review this and get back to you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corwin-of-amber @andersevenrud