Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent positioning of menu #28

Closed

Conversation

corwin-of-amber
Copy link
Contributor

This is a reattempt to get #27.

This is done by wrapping panel item content with a <div> and clamping
the context menu to it.
@corwin-of-amber
Copy link
Contributor Author

Ok I created a new one and still errors about using single quotes.

@corwin-of-amber
Copy link
Contributor Author

I noticed that all single-quoted strings have errors in Codacy, it only reports the ones in the diff upon submitting a PR.
https://app.codacy.com/manual/os-js/osjs-panels/issues/index?bid=8129109

@andersevenrud
Copy link
Member

Even though I disabled Cocay, it came back for unknown reasons. I disabled in in Github webhooks as well as the Codacy UI. I might just have to remove the repo link entirely or something.

I think the issue here is that Codacy don't read package.json, which is where I moved the eslint rules.

@andersevenrud
Copy link
Member

Closing, because #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants