Avoid calling is_running unnecessarily in kill
#6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `stop` function does the same check internally so it isn't required. Related ticket: https://progress.opensuse.org/issues/170209
|
Note that this doesn't fix the related issue. For this we need openSUSE/Mojo-IOLoop-ReadWriteProcess#61. |
okurz
approved these changes
Jan 13, 2025
perlpunk
approved these changes
Jan 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6110 +/- ##
==========================================
- Coverage 98.98% 98.98% -0.01%
==========================================
Files 396 396
Lines 39558 39556 -2
==========================================
- Hits 39158 39156 -2
Misses 400 400 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stopfunction does the same check internally so it isn't required.Related ticket: https://progress.opensuse.org/issues/170209