Merge pull request #6110 from Martchus/improve-kill

Avoid calling `is_running` unnecessarily in `kill`
os-autoinst · Jan 14, 2025 · 1b1680b · 1b1680b
2 parents 0771fde + 03a9219
commit 1b1680b
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/lib/OpenQA/Worker/Job.pm b/lib/OpenQA/Worker/Job.pm
@@ -315,14 +315,9 @@ sub _handle_engine_startup ($self, $engine, $max_job_time) {
     $self->_set_status(running => {});
 }
 
-sub kill {
-    my ($self) = @_;
-
-    my $engine = $self->engine;
-    return unless $engine;
-
-    my $child = $engine->{child};
-    $child->stop if $child && $child->is_running;
+sub kill ($self) {
+    return undef unless my $engine = $self->engine;
+    if (my $child = $engine->{child}) { $child->stop }
 }
 
 sub skip {